Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 when reviewer is deleted with integration tests #6856

Merged
merged 2 commits into from
May 6, 2019
Merged

Fix 500 when reviewer is deleted with integration tests #6856

merged 2 commits into from
May 6, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 6, 2019

will fix #6797

@lunny lunny added this to the 1.9.0 milestone May 6, 2019
@lunny lunny changed the title fix 500 when reviewer is deleted with integration tests Fix 500 when reviewer is deleted with integration tests May 6, 2019
@lunny lunny force-pushed the lunny/fix_removed_reviewer branch from 93a323c to fdbd10c Compare May 6, 2019 02:18
@codecov-io
Copy link

codecov-io commented May 6, 2019 •
edited
Loading

Codecov Report

Merging #6856 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6856      +/-   ##
==========================================
+ Coverage   41.14%   41.17%   +0.03%     
==========================================
  Files         425      425              
  Lines       58484    58489       +5     
==========================================
+ Hits        24061    24082      +21     
+ Misses      31236    31220      -16     
  Partials     3187     3187
Impacted Files Coverage Δ
models/issue_comment.go 47.48% <100%> (+0.57%) ⬆️
routers/repo/issue.go 35.87% <42.85%> (+0.29%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️
routers/user/home.go 49.89% <0%> (+0.63%) ⬆️
routers/repo/pull.go 36.86% <0%> (+0.72%) ⬆️
models/issue_comment_list.go 75.62% <0%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab38c3...ed253d8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 6, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2019
@lunny lunny merged commit 2382f1b into go-gitea:master May 6, 2019
lunny added a commit that referenced this pull request May 6, 2019
@lunny
fix 500 when reviewer is deleted with integration tests (#6856)
ad17d75
@lunny lunny deleted the lunny/fix_removed_reviewer branch May 6, 2019 12:12
@lunny lunny mentioned this pull request May 6, 2019
Merged
lafriks pushed a commit that referenced this pull request May 6, 2019
@lunny @lafriks
fix 500 when reviewer is deleted with integration tests (#6856) (#6860)
96eb99e
@lafriks lafriks added the backport/done All backports for this PR have been created label May 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

500 when opening a Pull Request assigned to a deleted user
6 participants
@lunny @codecov-io @zeripath @adelowo @lafriks @GiteaBot